CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1128043006/120001
https://codereview.chromium.org/1128043006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 7 (id:??) landed as
https://crrev.com/7f6ae2300b5da1a1118d14375d8113973e526153
Cr-Commit-Position: refs/heads/master@{#28417}
https://codereview.chromium.org/1128043006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #7 (id:120001)
https://codereview.chromium.org/1128043006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
This is ready for review. What is done in this CL is mostly refactoring. I
only
support C-style for loops in this CL.
Various forms of for-each made the CLe mashroom out of control, so I'll do
that
in subsequent CLs.
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc
File
LGTM
You have a todo about updating a comment. Now would be a good time to do
that.
https://codereview.chromium.org/1128043006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Seems like a step in the right direction.
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2425
src/parser.cc:2425: Expect(Token::ASSIGN, ok);
Maybe add a macro for CHECK_OK_VOID?
