[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-08 Thread brucedawson
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2219 src/compiler/ast-graph-builder.cc:2219: Node* value; It

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread mstarzinger
LGTM. https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313 src/compiler/ast-graph-builder.cc:2313: if

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread arv
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313 src/compiler/ast-graph-builder.cc:2313: if

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149133005/11 https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:11) https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread mstarzinger
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313 src/compiler/ast-graph-builder.cc:2313: if

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/06c706d84c04fc2e31e993518df9dcefb7543a2d Cr-Commit-Position: refs/heads/master@{#28815} https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-04 Thread arv
PTAL This is blocking my work on eval super https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-06-04 Thread arv
On 2015/06/04 17:15:06, arv wrote: PTAL This is blocking my work on eval super I unblocked it... Take your time. https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

[v8-dev] Re: [es6] Add TF for super.prop (issue 1149133005 by a...@chromium.org)

2015-05-29 Thread arv
PTAL This is now complete and ready for review. https://codereview.chromium.org/1149133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from