[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-12 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1186463002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Speculative revert for changing layout tests:

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-12 Thread machenbach
Note: In case you submitted a blink CL in the mean time, please always leave a note about that on the v8-side CL, then I don't revert. Note2: Your CQ_INCLUDE_TRYBOTS lacks a linebreak, otherwise the tests would have run I guess. https://codereview.chromium.org/1182513002/ -- -- v8-dev

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-12 Thread arv
On 2015/06/12 at 07:06:24, machenbach wrote: Note: In case you submitted a blink CL in the mean time, please always leave a note about that on the v8-side CL, then I don't revert. This time I didn't do a blink cl first. I didn't think blink would have tests impacted by this but to be sure

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182513002/1 https://codereview.chromium.org/1182513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3 Cr-Commit-Position: refs/heads/master@{#28968} https://codereview.chromium.org/1182513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1182513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread adamk
lgtm https://codereview.chromium.org/1182513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread arv
Thanks. https://codereview.chromium.org/1182513002/diff/1/test/mjsunit/function-bind-name.js File test/mjsunit/function-bind-name.js (right): https://codereview.chromium.org/1182513002/diff/1/test/mjsunit/function-bind-name.js#newcode12 test/mjsunit/function-bind-name.js:12:

[v8-dev] Re: [es6] Bound function names (issue 1182513002 by a...@chromium.org)

2015-06-11 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182513002/1 https://codereview.chromium.org/1182513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are