On 2015/05/06 15:39:37, arv wrote:
Andy, it looks like your CL is sticking around... I'll update this later
today.
I'm going to close this CL. I have a new patch that builds on this and it
correctly handles super.prop in arrows and eval.
https://codereview.chromium.org/1092503003/
--
--
I don't see the point of the Scope::scope_uses_super_property_ flag. For
user
feedback you want a location, for syntax you need to know that you're in a
constructor, and for the runtime, the use of the lexical this in the
various
SuperExpression AST nodes should be sufficient. Am I missing
On 2015/05/06 15:13:17, wingo wrote:
On 2015/05/06 14:58:13, arv wrote:
On 2015/05/06 14:47:38, wingo wrote:
I don't see the point of the Scope::scope_uses_super_property_ flag.
For
user
feedback you want a location, for syntax you need to know that you're
in a
constructor, and for
Andy, it looks like your CL is sticking around... I'll update this later
today.
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Andy, it looks like your CL is sticking around... I'll update this later
today.
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Andy, it looks like your CL is sticking around... I'll update this later
today.
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Oh, Reitveld O.o
On Wed, May 6, 2015 at 11:39 AM, a...@chromium.org wrote:
Andy, it looks like your CL is sticking around... I'll update this later
today.
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2015/05/06 14:47:38, wingo wrote:
I don't see the point of the Scope::scope_uses_super_property_ flag. For
user
feedback you want a location, for syntax you need to know that you're in a
constructor, and for the runtime, the use of the lexical this in the
various
SuperExpression AST
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h#newcode3266
src/preparser.h:3266: }
On 2015/05/06 14:47:38, wingo wrote:
Sounds like we could use a this_declaration_scope()
On 2015/05/06 14:58:13, arv wrote:
On 2015/05/06 14:47:38, wingo wrote:
I don't see the point of the Scope::scope_uses_super_property_ flag.
For
user
feedback you want a location, for syntax you need to know that you're
in a
constructor, and for the runtime, the use of the lexical this
On 2015/04/23 16:29:49, arv wrote:
Andy, did the lexical this CL land? If so I think super.prop in arrows
should
work now. I'll add tests if that is the case.
Lexical this hasn't landed yet, no, and a precursor just got rolled out so
it
will probably be next week. Good news though :)
On 2015/04/23 16:29:49, arv wrote:
Andreas, it is not clear how to fix the strong mode todo I added in
ParseSuperExpression.
I think it's actually correct as is, since the location is propagated up in
ParseArrowFunctionLiteral.
https://codereview.chromium.org/1092503003/
--
--
v8-dev
On 2015/04/24 15:15:41, arv wrote:
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h#newcode3284
src/preparser.h:3284: // TODO(rossberg): This might not be the correct
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1092503003/diff/40001/src/preparser.h#newcode3284
src/preparser.h:3284: // TODO(rossberg): This might not be the correct
FunctionState for the
Andreas, I'll remove
On 2015/04/24 06:31:45, wingo wrote:
On 2015/04/23 16:29:49, arv wrote:
Andy, did the lexical this CL land? If so I think super.prop in arrows
should
work now. I'll add tests if that is the case.
Lexical this hasn't landed yet, no, and a precursor just got rolled out
so it
will probably
PTAL
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1092503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
17 matches
Mail list logo
