[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/316b1e758b82cc2d06db96a4ef1105ecd50e77b9 Cr-Commit-Position: refs/heads/master@{#30165} https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288893003/1 https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread commit-...@chromium.org via codereview.chromium.org
This CL has an open dependency (Issue 1288333002 Patch 1). Please resolve the dependency and try again. https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread hpayer
On 2015/08/13 14:41:56, rmcilroy wrote: On 2015/08/13 13:59:32, rmcilroy wrote: > lgtm. Hannes: could you stamp for OWNERS please? Lgtm https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread rmcilroy
On 2015/08/13 13:59:32, rmcilroy wrote: lgtm. Hannes: could you stamp for OWNERS please? https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread rmcilroy
lgtm. https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread oth
lgtm, thanks! https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

[v8-dev] Re: [interpreter]: Fix interpreter handler table initialization. (issue 1288893003 by rmcil...@chromium.org)

2015-08-13 Thread rmcilroy
To give some background on why this is needed - turns out the builtins aren't generated at the time CreateUninitializedInterpreterTable is called. https://codereview.chromium.org/1288893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You receiv