[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/c97069e4a4351e86af0db55b2b9c3e5a0b56b8db Cr-Commit-Position: refs/heads/master@{#30527} https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305923005/40001 https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread littledan
I think you'll have to upload a separate, new patch to commit this. https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread littledan
lgtm https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-09-01 Thread gdeepti via v8-dev
PTAL. Added --harmony-simd flag to SimdJs.json to fix performance tests. https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" gro

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-31 Thread machenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1308003003/ by machenb...@chromium.org. The reason for reverting is: Breaks simdjs performance tests. See: https://paste.googleplex.com/5883927122149376. https://codereview.chromium.org/1305923005/ --

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-28 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-28 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/749ba3a13558cb018a2ec783e5dfb56d2f8528d8 Cr-Commit-Position: refs/heads/master@{#30452} https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-28 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305923005/20001 https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-27 Thread bmeurer
LGTM https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-27 Thread bbudge
LGTM but it would be nice to leave some indication of how to add them back (e.g. a commented out line that would do so.) That way, if we need the polyfill someday (to implement Phase 2 types) it will be easy. https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegr

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-27 Thread bbudge
Actually remove myself. https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop rece

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-27 Thread bbudge
Removing myself and adding Brad since he has a better understanding of how the tests work. https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google

[v8-dev] Re: [simd.js] Disable SIMD polyfill. (issue 1305923005 by gdee...@google.com)

2015-08-27 Thread littledan
lgtm https://codereview.chromium.org/1305923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from