[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread machenbach
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/1218123003/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Breaks gc stress: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%202/builds/3968. https://codereview.

[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 4 (id:??) landed as https://crrev.com/ea4e568363f48955e7de6b538e559132e9899c86 Cr-Commit-Position: refs/heads/master@{#29389} https://codereview.chromium.org/1193633003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #4 (id:80001) https://codereview.chromium.org/1193633003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193633003/80001 https://codereview.chromium.org/1193633003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread conradw
https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc#newcode21442 test/cctest/test-api.cc:21442: TEST(StrongModeAccessChecks) { On 2015/06/30 12:38:03, ros

[v8-dev] Re: [strong] Add tests for loading from proxy, super, with access checks (issue 1193633003 by conr...@chromium.org)

2015-06-30 Thread rossberg
lgtm https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc#newcode21442 test/cctest/test-api.cc:21442: TEST(StrongModeAccessChecks) { Can we also have a