[v8-dev] Re: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1255133002 by bmeu...@chromium.org)

2015-07-27 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/cac64b9f634743f7f5311d4dca8d50157b10fab5 Cr-Commit-Position: refs/heads/master@{#29881} https://codereview.chromium.org/1255133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1255133002 by bmeu...@chromium.org)

2015-07-27 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:40001) https://codereview.chromium.org/1255133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1255133002 by bmeu...@chromium.org)

2015-07-27 Thread ishell
lgtm https://codereview.chromium.org/1255133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1255133002 by bmeu...@chromium.org)

2015-07-27 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133002/40001 https://codereview.chromium.org/1255133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1255133002 by bmeu...@chromium.org)

2015-07-27 Thread bmeurer
Hey Igor, Here's the optimization we were talking about this morning. Basically we can handle read-only properties in fast path. Please take a look. Thanks, Benedikt https://codereview.chromium.org/1255133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-