[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

A revert of this CL (patchset #10 id:260001) has been created in https://codereview.chromium.org/1328963004/ by bmeu...@chromium.org. The reason for reverting is: Breaks nosnap, needs investigation. https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013008/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013008/280001 https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013008/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013008/280001 https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Patchset 11 (id:??) landed as https://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744 Cr-Commit-Position: refs/heads/master@{#30629} https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Committed patchset #11 (id:280001) https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Hey Jaro, Can you take a look at the x64 port before I start porting that over to everything else? Thanks, Benedikt https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

looks good so far. https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc#newcode1732 src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Code-stubs-* is looking good. https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h#newcode1957 src/code-stubs.h:1957: // and less horrible Invoke family of builtins. oh

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc#newcode1732 src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match the ES6 spec for

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Hey MIPS guys, Please port this CL to mips/mips64. Thanks, Benedikt https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev"

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Hey Michi, Michael, Please review the x64 or ia32 port (i'm about to port to arm). Please take a look. Thanks, Benedikt https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

LGTM. https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

It's just a regular code object. You need to provide a Callable for it in CodeFactory. Though this one might be a bit special since it takes a variable number of arguments (which tho should be hidden by your CallVarArgs). I thought this might be the case, thanks (just wanted to makes sure since

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Overall looks good, should be something that can be used by the Interpreter. I tried to figure out how to modify my CL to call this instead of the JSFunction code object directly, however I couldn't find a way to call a non-JS builtin from TF - is this not possible or am I missing something

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

On 2015/09/07 11:01:19, rmcilroy wrote: Overall looks good, should be something that can be used by the Interpreter. I tried to figure out how to modify my CL to call this instead of the JSFunction code object directly, however I couldn't find a way to call a non-JS builtin from TF - is

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Just tried this with the interpreter CallJS WIP CL and it works fine. LGTM, thanks! https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

LGTM here too. https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Hey Benedikt - Please find MIPS ports from Ákos in https://codereview.chromium.org/1311003006/ https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Patchset 10 (id:??) landed as https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277 Cr-Commit-Position: refs/heads/master@{#30627} https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

Committed patchset #10 (id:260001) https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013008/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013008/260001 https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [stubs] Unify the various versions of [[Call]] with CallCallableStub. (issue 1311013008 by bmeu...@chromium.org)

I renamed the builtins to Call and CallFunction to better match the spec names. https://codereview.chromium.org/1311013008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups