[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/35eb3a0260d349cb4201fed66ff62a438962bd47 Cr-Commit-Position: refs/heads/master@{#29288} https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205353002/1 https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205353002/1 https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread svenpanne
lgtm https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread bmeurer
https://codereview.chromium.org/1205353002/diff/1/src/macros.py File src/macros.py (right): https://codereview.chromium.org/1205353002/diff/1/src/macros.py#newcode194 src/macros.py:194: macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError(); On 2015/06/25 09:54:52, Sven Panne wrote:

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread svenpanne
https://codereview.chromium.org/1205353002/diff/1/src/macros.py File src/macros.py (right): https://codereview.chromium.org/1205353002/diff/1/src/macros.py#newcode194 src/macros.py:194: macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError(); Hopefully not followed by an "else"... :-]

[v8-dev] Re: [turbofan] Optimize BooleanNot conditions to Branch nodes. (issue 1205353002 by bmeu...@chromium.org)

2015-06-25 Thread bmeurer
Hey Sven, Another trivial optimization. Please take a look. Thanks, Benedikt https://codereview.chromium.org/1205353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-de