[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-08 Thread commit-bot
Patchset 6 (id:??) landed as https://crrev.com/584a351484b7423605b282386225f26622262d8d Cr-Commit-Position: refs/heads/master@{#27648} https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-08 Thread commit-bot
Committed patchset #6 (id:11) https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040603002/11 https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread bmeurer
Thanks. LGTM https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving email

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread jing . bao
On 2015/04/08 05:45:41, Benedikt Meurer wrote: Err, that was not what I meant. Since we still need to support machines without LZCNT, it is important to keep the macro assembler functions around, and use them. https://codereview.chromium.org/1040603002/diff/80001/src/compiler/x64/code-gene

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread bmeurer
Err, that was not what I meant. Since we still need to support machines without LZCNT, it is important to keep the macro assembler functions around, and use them. https://codereview.chromium.org/1040603002/diff/80001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread jing . bao
On 2015/04/08 04:36:21, Benedikt Meurer wrote: Looking good with nit. Can you also fix the two TODO(intel) in macro-assembler-x64.cc (MacroAssembler::Lzcntl)? https://codereview.chromium.org/1040603002/diff/60001/src/base/cpu.cc File src/base/cpu.cc (right): https://codereview.chromium.org/

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread bmeurer
Looking good with nit. Can you also fix the two TODO(intel) in macro-assembler-x64.cc (MacroAssembler::Lzcntl)? https://codereview.chromium.org/1040603002/diff/60001/src/base/cpu.cc File src/base/cpu.cc (right): https://codereview.chromium.org/1040603002/diff/60001/src/base/cpu.cc#newcode52 src

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-07 Thread weiliang . lin
Ping~ https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [x64] introduce BMI instructions (issue 1040603002 by jing....@intel.com)

2015-04-02 Thread weiliang . lin
On 2015/04/03 02:58:43, Jing wrote: LGTM, but still need Benedikt and danno's https://codereview.chromium.org/1040603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-de