LGTM, committed r6080.
I don't think we need objects-printer-inl.h, we only use them for inlining
larger functions, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=The_-inl.h_Files#The_-inl.h_Files.
I updated tools/gyp/v8.gyp, xcode anf Visual Studio files before commi
On 2010/12/17 13:44:03, Søren Gjesse wrote:
LGTM, with comment addressed.
When this is landed please make the refactoring of all the printing into
objects-printer.cc as suggested.
Will do. Do you want me to factor out the inline printer functions in
objects.h
into a objects-printer-inl.h
LGTM, with comment addressed.
When this is landed please make the refactoring of all the printing into
objects-printer.cc as suggested.
http://codereview.chromium.org/5998001/diff/35001/src/objects.h
File src/objects.h (right):
http://codereview.chromium.org/5998001/diff/35001/src/objects.h#n
