[v8-dev] Re: A64: Add overflow checking support for multiplications by constant powers of 2. (issue 210253002)

2014-03-25 Thread alexandre . rames
https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc File src/arm64/lithium-arm64.cc (right): https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc#newcode1914 src/arm64/lithium-arm64.cc:1914: !((constant >= -1) && (constant <= 2)); On 2014/03/25 08:2

[v8-dev] Re: A64: Add overflow checking support for multiplications by constant powers of 2. (issue 210253002)

2014-03-25 Thread ulan
lgtm https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc File src/arm64/lithium-arm64.cc (right): https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc#newcode1914 src/arm64/lithium-arm64.cc:1914: !((constant >= -1) && (constant <= 2)); Since (con