[v8-dev] Re: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (issue 206183005)

2014-03-20 Thread ulan
https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc File src/a64/stub-cache-a64.cc (right): https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc#newcode465 src/a64/stub-cache-a64.cc:465: (FLAG_track_double_fields representation.IsDouble()) ?

[v8-dev] Re: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (issue 206183005)

2014-03-20 Thread alexandre . rames
On 2014/03/20 10:39:36, ulan wrote: https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc File src/a64/stub-cache-a64.cc (right): https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc#newcode465 src/a64/stub-cache-a64.cc:465:

[v8-dev] Re: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (issue 206183005)

2014-03-20 Thread alexandre . rames
Updated... https://codereview.chromium.org/206183005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (issue 206183005)

2014-03-20 Thread ulan
lgtm https://codereview.chromium.org/206183005/diff/2/src/a64/stub-cache-a64.cc File src/a64/stub-cache-a64.cc (right): https://codereview.chromium.org/206183005/diff/2/src/a64/stub-cache-a64.cc#newcode464 src/a64/stub-cache-a64.cc:464: Register prop_reg = (representation.IsDouble()) ?

[v8-dev] Re: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (issue 206183005)

2014-03-20 Thread alexandre . rames
Committed patchset #2 manually as r20116 (presubmit successful). https://codereview.chromium.org/206183005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To