subject:"\[v8\-dev\] Re\: ARM\: Remove support for ABI prior to EABI \(issue6822025\)"

[v8-dev] Re: ARM: Remove support for ABI prior to EABI (issue6822025)

2011-04-11 Thread sgjesse

http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newcode951 src/arm/code-stubs-arm.cc:951: // registers 0 and 1. On 2011/04/11 08:48:02, Karl Klose wrote: r0

[v8-dev] Re: ARM: Remove support for ABI prior to EABI (issue6822025)

2011-04-11 Thread karlklose

LGTM. http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newcode951 src/arm/code-stubs-arm.cc:951: // registers 0 and 1. r0 and r1 instead of registers 0 and 1?