[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-12 Thread alexandre . rames
Any progress on this topic? https://codereview.chromium.org/308313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-12 Thread jarin
On 2014/06/12 13:08:08, Alexandre Rames wrote: Any progress on this topic? There seem to be too many complications in the register allocator to fix the constant handling there, so we decided against it (for now). One of the reasons why EmitAtUses() == false does not work is lowering of

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-03 Thread ulan
I am not sure why !info()-IsStub() check is triggering, but the approach with EmitAtUses seems much better. As Danno mentioned we would need a predicate for each architecture that decides if it is worthwhile to store constants in registers. https://codereview.chromium.org/308313002/ -- --

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-03 Thread danno
Actually, the right thing to do is to treat constants as normal values and teach the register allocator how to split constant ranges and rematerialize on demand without spilling. This is something that Jaro and Benedikt have thought about recently, and I think this is generally a cleaner way

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-03 Thread alexandre . rames
On 2014/06/03 08:01:16, danno wrote: Actually, the right thing to do is to treat constants as normal values and teach the register allocator how to split constant ranges and rematerialize on demand without spilling. This is something that Jaro and Benedikt have thought about recently, and I

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-03 Thread jarin
On 2014/06/03 08:27:25, Alexandre Rames wrote: On 2014/06/03 08:01:16, danno wrote: Actually, the right thing to do is to treat constants as normal values and teach the register allocator how to split constant ranges and rematerialize on demand without spilling. This is something that Jaro

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-02 Thread danno
DBC: Changes EmitAtUses to allocate Tagged constants in registers is generally a very bad thing for i32, so you will need more platform-specific machinery to abstract the decision. Could you provide more context for the ASSERT, perhaps the first few frames of the stack crawl?

[v8-dev] Re: ARM64: Avoid regeneration of constants. (issue 308313002)

2014-06-02 Thread alexandre . rames
On 2014/06/02 09:28:25, danno wrote: DBC: Changes EmitAtUses to allocate Tagged constants in registers is generally a very bad thing for i32, so you will need more platform-specific machinery to abstract the decision. Of course! This is just to highlight the bug met. Could you provide