[v8-dev] Re: ARM64: updated literal pool implementation. (issue 338523005 by rodolph.perfe...@arm.com)

2014-06-23 Thread rodolph . perfetta
Committed patchset #2 manually as r21924 (presubmit successful). https://codereview.chromium.org/338523005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: ARM64: updated literal pool implementation. (issue 338523005 by rodolph.perfe...@arm.com)

2014-06-19 Thread rmcilroy
lgtm, thanks! https://codereview.chromium.org/338523005/diff/1/src/arm64/assembler-arm64.h File src/arm64/assembler-arm64.h (right): https://codereview.chromium.org/338523005/diff/1/src/arm64/assembler-arm64.h#newcode2103 src/arm64/assembler-arm64.h:2103: // * code generation is finished On

[v8-dev] Re: ARM64: updated literal pool implementation. (issue 338523005 by rodolph.perfe...@arm.com)

2014-06-18 Thread rodolph . perfetta
I only plan one further patch to enable more instructions to use the literal pool for 64-bit immediate so more entries can be shared but that's it. Of course, We'll help landing OOL pool for arm64. https://codereview.chromium.org/338523005/diff/1/src/arm64/assembler-arm64.cc File

[v8-dev] Re: ARM64: updated literal pool implementation. (issue 338523005 by rodolph.perfe...@arm.com)

2014-06-17 Thread rmcilroy
Looks like a nice cleanup overall, couple of comments. Note - the Arm backend is very close to switching over to the OOL constant pool, and we want to switch Arm64 to this soon after. I'm not sure if you have any more plans for the Arm64 constant pool, but if so it may make more sense to

[v8-dev] Re: ARM64: updated literal pool implementation. (issue 338523005 by rodolph.perfe...@arm.com)

2014-06-14 Thread ulan
Adding Ross since he is working on constant pool too. https://codereview.chromium.org/338523005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe