[v8-dev] Re: Add ARM64 suppport to tools/grok_dump.py (issue 1149293005 by u...@chromium.org)

2015-06-03 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #4 (id:60001) https://codereview.chromium.org/1149293005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Add ARM64 suppport to tools/grok_dump.py (issue 1149293005 by u...@chromium.org)

2015-06-03 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 4 (id:??) landed as https://crrev.com/d903c5c0e55f7e3707bcc4390555bac21956c896 Cr-Commit-Position: refs/heads/master@{#28785} https://codereview.chromium.org/1149293005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Add ARM64 suppport to tools/grok_dump.py (issue 1149293005 by u...@chromium.org)

2015-06-03 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293005/60001 https://codereview.chromium.org/1149293005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Add ARM64 suppport to tools/grok_dump.py (issue 1149293005 by u...@chromium.org)

2015-06-03 Thread ulan
On 2015/06/03 10:41:49, Jakob wrote: Awesome, thank you very much! LGTM with a nit. https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py File tools/grokdump.py (right): https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py#newcode3188 tools/grokdump.py:

[v8-dev] Re: Add ARM64 suppport to tools/grok_dump.py (issue 1149293005 by u...@chromium.org)

2015-06-03 Thread jkummerow
Awesome, thank you very much! LGTM with a nit. https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py File tools/grokdump.py (right): https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py#newcode3188 tools/grokdump.py:3188: print "Could not disassemble using "