[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-07 Thread yurys
Committed patchset #1 manually as r22248 (presubmit successful). https://codereview.chromium.org/363553005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-07 Thread ulan
lgtm https://chromiumcodereview.appspot.com/363553005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving email

[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-03 Thread vsevik
Ulan, friendly ping. https://chromiumcodereview.appspot.com/363553005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop r

[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-01 Thread yangguo
https://codereview.chromium.org/363553005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-01 Thread yangguo
On 2014/07/01 14:03:54, kozyatinskiy wrote: Yang, please take a look. LGTM. Adding Ulan as this is a change to the API: do we need any more detailed description here? Also, I always found it weird that we are storing those values as Handle instead of simply int, but I guess this CL is the w

[v8-dev] Re: Add ScriptID field into ScriptOrigin class. (issue 363553005 by kozyatins...@google.com)

2014-07-01 Thread kozyatinskiy via v8-dev
Yang, please take a look. https://codereview.chromium.org/363553005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop rec