[v8-dev] Re: Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi (issue 20781007)

2013-08-20 Thread olivf
Committed patchset #6 manually as r16246. https://codereview.chromium.org/20781007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi (issue 20781007)

2013-08-01 Thread verwaest
I like this change. Lgtm with some nits. https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode4902 src/ia32/lithium-codegen-ia