Committed patchset #1 (id:1) manually as 24994 (presubmit successful).
https://codereview.chromium.org/688533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Thanks! Let me know if you want me to edit the 3 lines you pointed out and
the 1
I'm pointing out, or if you'll do that before landing. (I figured I'd miss
some;
http://build.chromium.org/p/chromium.fyi/builders/Cr%20Win%20Clang/builds/1226/steps/compile/logs/stdio
shows all these warnings and
LGTM. I'll land.
Michael: FYI (ast.h).
https://codereview.chromium.org/688533002/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/688533002/diff/1/src/ast.h#newcode1716
src/ast.h:1716: virtual void SetFirstICFeedbackSlot(FeedbackVectorICSlot
slot) {
The fact that we don
If I understand the discussion on chromium-dev
(https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo)
correctly, there are 2 steps after this:
* Replace "OVERRIDE" with "override" (and nuke our feature detection for
this).
* Remove all "virtual"s when there is an
jkummerow: If you like this, it'd be great if you could land it too. I'm
not a
v8 committer.
https://codereview.chromium.org/688533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Googl
fair point, done https://codereview.chromium.org/683363002
// Vyacheslav Egorov
On Wed, Oct 29, 2014 at 12:28 AM, Nico Weber wrote:
> (consider removing yourself from the owners file then?)
>
> On Tue, Oct 28, 2014 at 4:24 PM, wrote:
>
>> -me +jkummerow
>>
>> https://codereview.chromium.org/6
(consider removing yourself from the owners file then?)
On Tue, Oct 28, 2014 at 4:24 PM, wrote:
> -me +jkummerow
>
> https://codereview.chromium.org/688533002/
>
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
-me +jkummerow
https://codereview.chromium.org/688533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emai
