[v8-dev] Re: Add a flag to d8 to invoke weak callbacks (issue 306483006)

2014-05-27 Thread jochen
Committed patchset #2 manually as r21529 (presubmit successful). https://codereview.chromium.org/306483006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Add a flag to d8 to invoke weak callbacks (issue 306483006)

2014-05-27 Thread yangguo
LGTM with comment. https://codereview.chromium.org/306483006/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/306483006/diff/1/src/d8.cc#newcode1387 src/d8.cc:1387: } This duplicate code could be factored out into a helper function. https://codereview.chromium.org/30648