[v8-dev] Re: Add assembler.h the the Visual Studio project file.

2008-09-19 Thread Søren Gjesse
Right - switched .cc and .h. The Visual Studio UI sorts the files independent of the order in the .vcproj file anyway though. /Søren On Fri, Sep 19, 2008 at 10:42 AM, Kasper Lund <[EMAIL PROTECTED]> wrote: > > Usually the .h files come after the .cc files in the list, but other > than that it LGT

[v8-dev] Re: Add assembler.h the the Visual Studio project file.

2008-09-19 Thread Christian Plesner Hansen
lgtm On Fri, Sep 19, 2008 at 10:06 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: christian.plesner.hansen, > > Description: > Add assembler.h the the Visual Studio project file. > > Please review this at http://codereview.chromium.org/2985 > > Affected files: > M tools/visual_studio/v8_base.v

[v8-dev] Re: Add assembler.h the the Visual Studio project file.

2008-09-19 Thread Kasper Lund
Usually the .h files come after the .cc files in the list, but other than that it LGTM. On Fri, Sep 19, 2008 at 10:06 AM, <[EMAIL PROTECTED]> wrote: > > Reviewers: christian.plesner.hansen, > > Description: > Add assembler.h the the Visual Studio project file. > > Please review this at http://co