I think the approach looks right. We should make sure to come up with
tests that hit all the new code paths.
http://codereview.chromium.org/21538/diff/1/2
File src/codegen-ia32.h (right):
http://codereview.chromium.org/21538/diff/1/2#newcode483
Line 483: void SmiOperation(Result* operand,
Make
I think the code to free eax and edx has turned out very
nicely. It starts at codegen-ia32.cc:5400. See what you think.
We need to go from the situation where "answer" is a free register that
is a copy of left to the situation where eax and edx are free registers,
and eax is a copy of left. Lef
The register shuffling code looks good. I'm not sure if there's any
good way to abstract it or if we just handle it on a case-by-case basis.
We'll see as we hit more cases like this.
http://codereview.chromium.org/21538/diff/2001/2003
File src/codegen-ia32.cc (right):
http://codereview.chrom
Still debugging - not ready for final review.
http://codereview.chromium.org/21538/diff/2001/2003
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/21538/diff/2001/2003#newcode753
Line 753: Result GenerateInlineCode(Result* left, Result* right);
On 2009/02/23 09:10:16, Kevin Mill
Here is the changelist. Please review it. Thanks.
http://codereview.chromium.org/21538
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Lots of comments, mostly style.
http://codereview.chromium.org/21538/diff/4001/4003
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/21538/diff/4001/4003#newcode692
Line 692: // is inlined or should be dealt with in the stub.
...or is unneeded.
http://codereview.chromium.org/21
http://codereview.chromium.org/21538/diff/4001/4003
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/21538/diff/4001/4003#newcode692
Line 692: // is inlined or should be dealt with in the stub.
On 2009/02/25 21:28:58, Kevin Millikin wrote:
> ...or is unneeded.
Done.
http://code
OK, I'll take another look.
On Thu, Feb 26, 2009 at 2:18 PM, wrote:
>
> http://codereview.chromium.org/21538/diff/4001/4003
> File src/codegen-ia32.cc (right):
>
> http://codereview.chromium.org/21538/diff/4001/4003#newcode692
> Line 692: // is inlined or should be dealt with in the stub.
> On 2
This changelist has moved from experimental compiler branch to
bleeding-edge, with a new issue number,
http://codereview.chromium.org/42006.
http://codereview.chromium.org/21538
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google
