Committed patchset #4 manually as r16733 (presubmit successful).
https://codereview.chromium.org/23890027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/16 09:52:54, Sven Panne wrote:
Hmmm, we have test failures in cctest/test-flags, see e.g.
make -j32 ia32.debug.check TESTJOBS="cctest/test-flags"
So we need one more review round. *Nothing* in v8 is easy... :-}
Whoops, I thought I'd run debug.check... Fixed and added some
Hmmm, we have test failures in cctest/test-flags, see e.g.
make -j32 ia32.debug.check TESTJOBS="cctest/test-flags"
So we need one more review round. *Nothing* in v8 is easy... :-}
https://codereview.chromium.org/23890027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Thanks. Could you land this for me please?
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc
File src/flags.cc (right):
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc#newcode421
src/flags.cc:421: PrintF("Setting %d\n", !is_bool);
On 2013/09/16 07:50:45, Sven Pann
LGTM. Our 2-step Isolate initialization + the code executed before main() is
nice, isn't it? :-]
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc
File src/flags.cc (right):
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc#newcode421
src/flags.cc:421: PrintF("Settin
On 2013/09/13 12:34:52, Sven Panne wrote:
Three-valued logic via 2 boolean + exclusion of one of the 4 possible
combined
values => not exactly a candidate for the next coding beauty
contest... ;-)
How about this instead - enabled the use of Maybe flag types.
Also fixed an issue with the iso
Three-valued logic via 2 boolean + exclusion of one of the 4 possible
combined
values => not exactly a candidate for the next coding beauty contest... ;-)
https://codereview.chromium.org/23890027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
LGTM
https://codereview.chromium.org/23890027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
