Thanks Pavel,
But could you please put in a V8 test as well, as we don't want catching
issues with this in layout tests.
Regards,
Søren
On Fri, Jan 14, 2011 at 10:57, Pavel Podivilov wrote:
> Sure, DevTools would set breakpoints using this function so it would
> definitely be tested by layout
Sure, DevTools would set breakpoints using this function so it would
definitely be tested by layout tests.
BR,
Pavel Podivilov
On Thu, Jan 13, 2011 at 11:40 PM, Søren Gjesse wrote:
> OK, will this be tested in some of the DevTools tests? Otherwise this might
> get broken without anybody notici
OK, will this be tested in some of the DevTools tests? Otherwise this might
get broken without anybody noticing.
/Søren
On Thu, Jan 13, 2011 at 18:32, wrote:
> On 2011/01/13 15:46:14, Søren Gjesse wrote:
>
>> LGTM, but the function is not used anywhere.
>>
>
> It will be used from WebCore Debug
On 2011/01/13 15:46:14, Søren Gjesse wrote:
LGTM, but the function is not used anywhere.
It will be used from WebCore DebuggerScript.js
http://codereview.chromium.org/6301001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, but the function is not used anywhere.
http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js#newcode653
src/debug-debugger.js:653: Debug.setBreakPointByScriptIdAndPosition
