[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-18 Thread yurys
Committed patchset #5 manually as r18334 (presubmit successful). https://codereview.chromium.org/93843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-09 Thread hpayer
lgtm https://codereview.chromium.org/93843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-09 Thread mstarzinger
LGTM (rubber-stamped). https://codereview.chromium.org/93843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-06 Thread yurys
Hannes or Michael, can you do OWNER review please? https://codereview.chromium.org/93843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-04 Thread yurys
https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500 src/api.cc:7500: nit: add an empty line Done. https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profiler.cc#newcode1067 test/cctest/test-heap-profiler.cc:1067: heap_profiler->StopTrackingHeapObjects(); May

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-04 Thread alph
lgtm https://codereview.chromium.org/93843004/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500 src/api.cc:7500: nit: add an empty line https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profiler.cc File test/

[v8-dev] Re: Add methods for finding object by its snapshot id and id for an object (issue 93843004)

2013-12-04 Thread yurys
https://codereview.chromium.org/93843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send