This is in Canary 2396
It is referenced from
https://code.google.com/p/chromium/issues/detail?id=486005
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 8 (id:??) landed as
https://crrev.com/ae6a0b807574d4349be9c45428960ac7ecd3679a
Cr-Commit-Position: refs/heads/master@{#28300}
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #8 (id:140001)
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1105293004/140001
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
lgtm
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc#newcode199
src/heap/gc-idle-time-handler.cc:199: // if
can_start_incremen
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.h#newcode152
src/heap/gc-idle-time-handler.h:152: static const int
kGCsBeforeM
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc#newcode199
src/heap/gc-idle-time-handler.cc:199: // if
can_start_incremen
Thank you for reviewing! I uploaded new PS.
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc#newcode198
src/heap/gc-idle-
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc#newcode198
src/heap/gc-idle-time-handler.cc:198: // In kReduceLatency mod
We would have to move the counters to heap, and add them to the HeapState to
make testing nice. Well, we probably don't have to go all the way. The test
you
wrote look fine. So, fine with me.
LGTM, with just one nit.
FYI Ross, this CL removes kMaxNoProgressIdleTimesPerIdleRound and goes to
Thanks, I uploaded new PS.
Please add unit tests for the helper functions like NextMode.
This is tested as part of the public interface (the Compute function).
To test the private functions separately, we would need to expose the
private
state and allow setting the mode and counters outside
Looking good overall.
Please run the smoothness test to see if we tank latency.
Please add unit tests for the helper functions like NextMode.
https://codereview.chromium.org/1105293004/diff/80001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://coderevie
13 matches
Mail list logo
