[v8-dev] Re: Add parens to DateYMDFromTimeSlow to clearify. (issue1132002)

2010-03-19 Thread Oleg Eterevsky
Definitely LGTM then. On Fri, Mar 19, 2010 at 16:01, Mads Sig Ager wrote: > This one was not purely about readability.  GCC gave warnings on this > one because there were combinations of && and || with no parenthesis > to clearify precedence. > > -- Mads > > On Fri, Mar 19, 2010 at 1:57 PM, Oleg

[v8-dev] Re: Add parens to DateYMDFromTimeSlow to clearify. (issue1132002)

2010-03-19 Thread Mads Sig Ager
This one was not purely about readability. GCC gave warnings on this one because there were combinations of && and || with no parenthesis to clearify precedence. -- Mads On Fri, Mar 19, 2010 at 1:57 PM, Oleg Eterevsky wrote: > To me extra parentheses make the code less readable, but obviously y

[v8-dev] Re: Add parens to DateYMDFromTimeSlow to clearify. (issue1132002)

2010-03-19 Thread Oleg Eterevsky
To me extra parentheses make the code less readable, but obviously you know the project style guidelines better than myself. On Fri, Mar 19, 2010 at 10:52, wrote: > LMRTM (Looks More Readable To Me) > > http://codereview.chromium.org/1132002 > -- v8-dev mailing list v8-dev@googlegroups.com htt

[v8-dev] Re: Add parens to DateYMDFromTimeSlow to clearify. (issue1132002)

2010-03-19 Thread sgjesse
LMRTM (Looks More Readable To Me) http://codereview.chromium.org/1132002 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as th