Committed patchset #5 manually as r21653 (presubmit successful).
https://codereview.chromium.org/304143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM
Done. I'm not convinced this is clearer though.
This seems slightly more readable to me, but that's subjective. I don't have
strong preference on this, feel free to land the previous version of
ClearPtrEntries.
https://codereview.chromium.org/304143002/
--
--
v8-dev mailing list
v8-dev@
On 2014/06/02 13:14:00, mvstanton wrote:
Just as a DBC: this is great. I'm thinking to be able to use these handy
ConstantPoolArrays as elements in the feedback vector when feedback for a
particular node (say a LoadIC) would like to store code addresses as well
as
object pointers. You've solve
Thanks for the review Ulan, PTAL.
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc#newcode134
src/factory.cc:134: Handle
Factory::NewExtendedConstantPoolArray(
On 2014/06/02 12:32
Just as a DBC: this is great. I'm thinking to be able to use these handy
ConstantPoolArrays as elements in the feedback vector when feedback for a
particular node (say a LoadIC) would like to store code addresses as well as
object pointers. You've solved a thorny problem and type vector code could
I like the heap pointer iterator! Looks good overall, small suggestions
below.
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc#newcode134
src/factory.cc:134: Handle
Factory::Ne
