Change the commit message to say "Add unit test for the 64-bit
assembler."
I'm concerned about multiplication of testing configurations. Is it
possible to arch=x64 on Windows and Mac? If so, does this test pass?
http://codereview.chromium.org/115707/diff/11/12
File test/cctest/test-assembler-
Currently arch=x64 doesn't work in Windows (it doesn't pass any extra flags
to the compiler, but it assumes that we have a 64-bit memory model).It
should "work" on Mac, since it uses GCC as well.
2009/5/22 kmillikin
>
> Change the commit message to say "Add unit test for the 64-bit
> assembler."
Comments addressed. Windows platform is currently not implemented.
http://codereview.chromium.org/115707/diff/11/12
File test/cctest/test-assembler-x64.cc (right):
http://codereview.chromium.org/115707/diff/11/12#newcode57
Line 57: v8::internal::byte* buffer;
On 2009/05/22 13:20:54, Kevin Mill
