[v8-dev] Re: Added a debugger call to run a JavaScript function in the debugger. When call...

2008-11-27 Thread sgjesse
http://codereview.chromium.org/12472/diff/9/210 File include/v8-debug.h (right): http://codereview.chromium.org/12472/diff/9/210#newcode132 Line 132: // Run a JavaScript function in the debugger. On 2008/11/27 07:09:08, Christian Plesner Hansen wrote: > From this comment it's not obvious what th

[v8-dev] Re: Added a debugger call to run a JavaScript function in the debugger. When call...

2008-11-26 Thread christian . plesner . hansen
Lgtm http://codereview.chromium.org/12472/diff/9/210 File include/v8-debug.h (right): http://codereview.chromium.org/12472/diff/9/210#newcode132 Line 132: // Run a JavaScript function in the debugger. From this comment it's not obvious what this means, exactly. Is it just a way to get your ha

[v8-dev] Re: Added a debugger call to run a JavaScript function in the debugger. When call...

2008-11-26 Thread sgjesse
Added a function which captures a context variable as an additional test. http://codereview.chromium.org/12472/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/12472/diff/1/4#newcode2907 Line 2907: if (!i::V8::HasBeenSetup()) v8::Undefined(); On 2008/11/26 15:02:42, Mads Ager wr

[v8-dev] Re: Added a debugger call to run a JavaScript function in the debugger. When call...

2008-11-26 Thread ager
LGTM. Maybe you can add a test that shows what happens if you pass in a closure that uses local variables from its context: var x = 3; function (execstate) { execstate.something == x; } This should just work, but a test would be nice. http://codereview.chromium.org/12472/diff/1/4 File src/