https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc#newcode3339
src/hydrogen-instructions.cc:3339:
This method is getting pretty big; suggest p
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc#newcode3339
src/hydrogen-instructions.cc:3339:
On 2013/08/06 12:24:12, titzer wrote:
This
https://codereview.chromium.org/22378003/diff/29002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/29002/src/hydrogen-instructions.cc#newcode3484
src/hydrogen-instructions.cc:3484: HConstant* filler_map =
HConstant::New(
You
https://codereview.chromium.org/22378003/diff/29002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/29002/src/hydrogen-instructions.cc#newcode3484
src/hydrogen-instructions.cc:3484: HConstant* filler_map =
HConstant::New(
On 2
lgtm
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/22378003/diff/38001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/38001/src/hydrogen-instructions.cc#newcode3431
src/hydrogen-instructions.cc:3431: // space memory.
nit: Seems like an "otherwi
https://codereview.chromium.org/22378003/diff/38001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/38001/src/hydrogen-instructions.cc#newcode3452
src/hydrogen-instructions.cc:3452:
UpdateFreeSpaceFiller(dominator_free_space_s
LGTM.
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2013/08/09 12:46:08, Michael Starzinger wrote:
LGTM.
Update: mstarzinger model checker found a bug when old space allocations of
different old spaces do not occur in alternating order. Adding the filler
map
right before the dominating allocate of the "other" old space should fix
that
pr
https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc#newcode3366
src/hydrogen-instructions.cc:3366:
filler_free_space_size_->DeleteAndReplaceWit
https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc#newcode3366
src/hydrogen-instructions.cc:3366:
filler_free_space_size_->DeleteAndReplaceWit
lgtm
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #12 manually as r16346 (presubmit successful).
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
13 matches
Mail list logo