[v8-dev] Re: Added regexp tests from PCRE.

2009-02-02 Thread christian . plesner . hansen
This code review is broken; file is too large. http://codereview.chromium.org/19751 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Added regexp tests from PCRE.

2009-02-02 Thread christian . plesner . hansen
Lgtm. I would add a comment that explains that the fact that we have tests including stuff like \p{SomeObscureCharacter} doesn't mean that we support it. http://codereview.chromium.org/19751 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http:/

[v8-dev] Re: Added regexp tests from PCRE.

2009-02-02 Thread erik . corry
http://codereview.chromium.org/19751 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---