Committed patchset #2 (id:20001)
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/a1a7cfd6ba42082179c160d855e4941218a251b7
Cr-Commit-Position: refs/heads/master@{#29041}
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1182303004/20001
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Thanks for the review. Fixed nits, ptal.
https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but
that would be w
+1
Non own private is not useful. (We could always add it back if we ever
needed it.)
On Mon, Jun 15, 2015 at 8:54 AM, wrote:
> +1, anything else doesn't seem to make sense
>
>
> https://codereview.chromium.org/1182303004/
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://gro
+1, anything else doesn't seem to make sense
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but
that would be way slower).
Is this comment still needed? I
