Committed patchset #1 manually as r18253 (presubmit successful).
https://codereview.chromium.org/101783005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Hi guys,
I prefer this style because it's object-oriented. Fields of a single object
deserve an encapsulating structure, and the case statement does that. If
each
field access for a single object has to be maintained with three or 4 lines
that
only appear "together" by convention in the header
https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc#newcode4272
src/hydrogen-instructions.cc:4272: HObjectAccess
HObjectAccess::ForAllocationSiteOffs
https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc#newcode4272
src/hydrogen-instructions.cc:4272: HObjectAccess
HObjectAccess::ForAllocationSiteOffs
LGTM
https://codereview.chromium.org/101783005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
