LGTM with one nit: please use int instead of unsigned where possible to
avoid mixing them.
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
On 2014/05/23 10:31:58, ulan wrote:
LGTM with one nit: please use int instead of unsigned where possible
to
avoid mixing them.
Uploaded the fixed patch. Can you confirm it's still ok?
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Yep, lgtm
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #3 manually as r21468 (presubmit successful).
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
On 2014/05/22 12:57:03, Alexandre Rames wrote:
The diff includes the diff for issue 296993002 since git cl uploaded
everything,
DBC: You can use git cl upload my_other_branch to upload the diff to
my_other_branch (which can be any commit descriptor git understands).
On 2014/05/22 13:01:09, Jakob wrote:
On 2014/05/22 12:57:03, Alexandre Rames wrote:
The diff includes the diff for issue 296993002 since git cl uploaded
everything,
DBC: You can use git cl upload my_other_branch to upload the diff to
my_other_branch (which can be any commit descriptor git
