[v8-dev] Re: Arm support for DoubleToIStub (truncating). (issue 23129003)

2013-08-20 Thread bmeurer
lgtm https://chromiumcodereview.appspot.com/23129003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Arm support for DoubleToIStub (truncating). (issue 23129003)

2013-08-19 Thread bmeurer
Ok, first round of comments. https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683 src/arm/code-stubs-arm.cc:683: // with exponent because

[v8-dev] Re: Arm support for DoubleToIStub (truncating). (issue 23129003)

2013-08-19 Thread rmcilroy
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683 src/arm/code-stubs-arm.cc:683: // with exponent because Bias + 1 = 1024 which is an