[v8-dev] Re: Augment trace-ic to provide information on patching inlined loads. (issue2818023)

2010-06-22 Thread erik . corry
I didn't do the other inlined cases. Another time perhaps. I put the logging in ifdefs so it doesn't go in the release version. http://codereview.chromium.org/2818023/diff/1/2 File src/ic.cc (right): http://codereview.chromium.org/2818023/diff/1/2#newcode734 src/ic.cc:734: if (FLAG_trace_ic)

[v8-dev] Re: Augment trace-ic to provide information on patching inlined loads. (issue2818023)

2010-06-22 Thread sgjesse
LGTM How about the other types which can be inlined? http://codereview.chromium.org/2818023/diff/1/2 File src/ic.cc (right): http://codereview.chromium.org/2818023/diff/1/2#newcode734 src/ic.cc:734: if (FLAG_trace_ic) PrintF("[LoadIC : patch %s ]\n", *name->ToCString()); Maybe remove this line