Thanks for the review Erik!
Landing.
I will also create a Wiki and Issues to cover current progress.
http://codereview.chromium.org/5965011/diff/12016/SConstruct
File SConstruct (right):
http://codereview.chromium.org/5965011/diff/12016/SConstruct#newcode882
SConstruct:882: Abort("GDBJIT inte
Cool. I'll try it out.
Danno
On Wed, Jan 5, 2011 at 10:00 AM, wrote:
> LGTM
>
>
> http://codereview.chromium.org/5965011/diff/12016/SConstruct
> File SConstruct (right):
>
> http://codereview.chromium.org/5965011/diff/12016/SConstruct#newcode882
> SConstruct:882: Abort("GDBJIT interface is suppo
LGTM
http://codereview.chromium.org/5965011/diff/12016/SConstruct
File SConstruct (right):
http://codereview.chromium.org/5965011/diff/12016/SConstruct#newcode882
SConstruct:882: Abort("GDBJIT interface is supported only for 32-bit
Linux target.")
32-bit should perhaps be Intel-compatible?
htt
http://codereview.chromium.org/5965011/diff/12016/src/gdbjit.cc
File src/gdbjit.cc (right):
http://codereview.chromium.org/5965011/diff/12016/src/gdbjit.cc#newcode95
src/gdbjit.cc:95: Slot SlotHere() {
The name should reflect the fact that this function (and the next)
create slots. eg CreateSlo
Redirecting CL to Erik.
http://codereview.chromium.org/5965011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I've added a number of small tweaks to the changelist.
1) to reduce pressure on GDB now I emit ELF objects only for code that has
a meaningful line information attached. Ryan's sample now starts in a
reasonable amount of time.
2) I fixed a small bug in .debug_line section writer. But stepping thr
Thanks for testing it Ryan!
I fixed the release build.
But it seems that GDB itself is not optimized to handle many small ELF
objects: I just commented calls to __jit_debug_register_code (leaving all
ELF generation in place) and everything started working fast.
This is extremely disappointing. I
Tested in Node (
https://github.com/ry/node/commit/3f45187815ba043ef04b591da53d6cacb11937c1
) and
it seems to work. It's extremely slow though; like 5 minutes to start a
hello
world http server. Is it possible to run on non-debug builds?
http://codereview.chromium.org/5965011/
--
v8-dev mai
