[v8-dev] Re: Cache multiple ElementsKind map transition per map. (issue 8017003)

2011-09-25 Thread danno
Feedback addressed, landing. http://codereview.chromium.org/8017003/diff/8001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8017003/diff/8001/src/objects.cc#newcode6509 src/objects.cc:6509: // Verify target. On 2011/09/23 13:49:23, Vyacheslav Egorov wrote: Can we a

[v8-dev] Re: Cache multiple ElementsKind map transition per map. (issue 8017003)

2011-09-23 Thread vegorov
lgtm http://codereview.chromium.org/8017003/diff/8001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8017003/diff/8001/src/objects.cc#newcode6509 src/objects.cc:6509: // Verify target. Can we avoid code duplication by moving these asserts + *RawField() = this to some

[v8-dev] Re: Cache multiple ElementsKind map transition per map. (issue 8017003)

2011-09-23 Thread danno
Slava, can you please take a look at the GC bug fixes? Thanks. http://codereview.chromium.org/8017003/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8017003/diff/1/src/objects.cc#newcode2081 src/objects.cc:2081: new_array->set(i, FixedArray::cast(descriptor_co

[v8-dev] Re: Cache multiple ElementsKind map transition per map. (issue 8017003)

2011-09-23 Thread jkummerow
LGTM http://codereview.chromium.org/8017003/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8017003/diff/1/src/objects.cc#newcode2081 src/objects.cc:2081: new_array->set(i, FixedArray::cast(descriptor_contents)->get(i)); Simplification: s/FixedArray::cast(descr