[v8-dev] Re: Change FastCharCodeAt to use a virtual frame.

2009-01-30 Thread kmillikin
I didn't pore over the code too closely, but it looks OK. If it passes all the tests we have in both modes, then put it in and see if it makes any difference. http://codereview.chromium.org/19425 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com h

[v8-dev] Re: Change FastCharCodeAt to use a virtual frame.

2009-01-30 Thread whesse
http://codereview.chromium.org/19425/diff/1/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/19425/diff/1/3#newcode3480 Line 3480: set_in_spilled_code(false); On 2009/01/29 10:16:53, Kevin Millikin wrote: > Don't forget to remove this. When I merge with the current version of

[v8-dev] Re: Change FastCharCodeAt to use a virtual frame.

2009-01-29 Thread kmillikin
I know this isn't completed or tested, but I found some possible sources of bugs. As for your specific questions, I really don't know. It seems like we should probably get it working, and then experiment with various versions on benchmarks where it gets exercised. http://codereview.chromium.or