thx, Hannes, have another look then,
--Michael
https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9037
src/objects.cc:9037: Address site_address =
(reinterpret_cast<Address>(site) -
On 2013/09/16 16:12:56, Michael Starzinger wrote:
nit: As discussed offline with Hannes, better use
Heap::InOldPointerSpace(Object*) here.
Done.
https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9040
src/objects.cc:9040: object->GetHeap()->Contains(site_address)) {
On 2013/09/16 16:12:05, Hannes Payer wrote:
Instead of checking the whole heap, you could check if the address is
in old
pointer space since this is the place where allocation sites should be
allocated.
Done.
https://codereview.chromium.org/23606032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
