LGTM.
http://codereview.chromium.org/119414/diff/1/8
File src/arm/frames-arm.h (right):
http://codereview.chromium.org/119414/diff/1/8#newcode330
Line 330: // C entry frames: When calling from JS to C, we construct one
extra
Unless you're sure this is still valid, I would remove the diagrams.
T
Ooops, I meant to do that (they're already gone from ia32). Thanks for the
catch.
On Wed, Jun 10, 2009 at 10:40 AM, wrote:
> LGTM.
>
>
> http://codereview.chromium.org/119414/diff/1/8
> File src/arm/frames-arm.h (right):
>
> http://codereview.chromium.org/119414/diff/1/8#newcode330
> Line 330:
Lasse, you may want to take a quick look at the x64 files.
http://codereview.chromium.org/119414
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---