[v8-dev] Re: CodeStubs contain their corresponding Isolate* now. (part 1) (issue 246643014)

2014-04-23 Thread svenpanne
Committed patchset #2 manually as r20919 (presubmit successful). https://codereview.chromium.org/246643014/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: CodeStubs contain their corresponding Isolate* now. (part 1) (issue 246643014)

2014-04-23 Thread svenpanne
Addressed comments, landing... https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (left): https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#oldcode3787 src/arm/code-stubs-arm.cc:3787: On 2014/04/23 13:58:21, Michael

[v8-dev] Re: CodeStubs contain their corresponding Isolate* now. (part 1) (issue 246643014)

2014-04-23 Thread mstarzinger
LGTM, just nits. https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (left): https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#oldcode3787 src/arm/code-stubs-arm.cc:3787: nit: Can we get the empty newline back for re