On 2014/12/20 23:03:22, michael_dawson wrote:
[...] If there was a better way to do this just let me know.
I don't think so, closing this issue...
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
Since I was not the owner of this issue I could not upload this patch on
this issue.
I therefore uploaded on a new issue:
https://codereview.chromium.org/817143002/
If there was a better way to do this just let me know.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8
On 2014/11/11 13:13:50, Sven Panne wrote:
On 2014/09/15 17:53:16, andrew_low wrote:
> [...] I will keep this one around and chop it down to only the changes
required to
> hook in the PowerPC implementation.
OK, then endianess-related changes and the ppc directories have been
landed,
so
you c
On 2014/09/15 17:53:16, andrew_low wrote:
[...] I will keep this one around and chop it down to only the changes
required to
hook in the PowerPC implementation.
OK, then endianess-related changes and the ppc directories have been
landed, so
you can remove these changes from this CL, leaving
Reviewers: danno, Sven Panne, rmcilroy_OOO_until_Sept_17,
Message:
I've now (again) caught the PowerPC code base up to the very latest bleeding
edge.
As was suggested, I've broken off non-PowerPC specific changes into a patch
for
big-endian support. https://codereview.chromium.org/551803004/
I just started to look a little bit into the reviewable parts, see the
individual comments below. Instead of fixing these in this CL, I propose to
split up the CL into manageable parts as follows:
* The first CL should just contain fixes for big-endian support in the
current v8, no PowerPC stu
Deleted and re-uploaded the patch set as requested.
I suspect the same problem will manifest as I continue to get an error from
the
tooling when doing the upload. My guess is that the size/scope of this
patch is
so large that we hit some sort of time-out.
I'm open to hacking my tooling or w
On 2014/08/19 17:08:04, Jakob wrote:
Sorry, reviewing bandwidth is a bit of an issue right now with many people
being
on vacation. We'll find someone to take a look at the current state of
this
patch.
I'm just back from my vacation, and I can have look. The problem is that I
get
quite a f
Sorry, reviewing bandwidth is a bit of an issue right now with many people
being
on vacation. We'll find someone to take a look at the current state of this
patch.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Caught up to bleeding edge as of 8/19.
Code ready for additional reviews / merge at this point.
I did get caught between
$git cl format
$git cl presubmit
Format wanted to change one of the files (removing spaces) that then were
flagged in presubmit. I picked the logical correct (with spaces) ve
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc#newcode532
src/objects-printer.cc:532: os << "\n [" << i << "]: int64: " <<
get_int64_entry(i);
On 2014/08
The architecture-indepent constant pool changes look good to me (with a
comment
on object-printer.cc), thanks!
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/422063005/diff/40001/src/objects-prin
On 2014/08/15 20:34:34, andrew_low wrote:
Finally got caught up to bleeding edge again.
Code is again ready for tire-kicking.
The architecture-independed constant pool changes look good to me, thanks!
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.
Finally got caught up to bleeding edge again.
Code is again ready for tire-kicking.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "
Turbofan isn't ready for prime-time yet anyway, so you definitely don't
need to
implement the entire backend right away. The changes required for being
able to
compile and run tests (with TF disabled) should be fairly small; you can
look at
the mips/mips64/x87 ports for examples.
Looking at
I haven't forgotten about this (huge) patch, just getting past the TurboFan
update etc. No action from the V8 team for now until I get an updated patch
up.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Y
Yes, that seem correct. Let me know if you have any issues doing this.
On 31 July 2014 17:29, wrote:
> Would like some advice on the best way to keep this patch current relative
> to
> the bleeding edge.
>
> This set of patches will no longer cleanly apply.
>
> I'm using the git svn / git cl i
Would like some advice on the best way to keep this patch current relative
to
the bleeding edge.
This set of patches will no longer cleanly apply.
I'm using the git svn / git cl integration.
So I think I'm supposed to:
$ git svn fetch
$ git svn rebase master
$ git cl rebase
.. fix issues ..
$
On 2014/07/29 17:11:46, rmcilroy wrote:
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h#newcode2605
src/objects-inl.h:2605: WRITE_UINT32_FIELD(this, kSmallLayout3Offset,
small_
At this point I've addressed the first set of comments from danno, the
latest
patch should represent the set of changes.
As suggested - some of the code has been broken out to other commits:
https://codereview.chromium.org/430523002/
https://codereview.chromium.org/427863003/
I will now work o
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h#newcode2605
src/objects-inl.h:2605: WRITE_UINT32_FIELD(this, kSmallLayout3Offset,
small_layout_3);
Why did you have to add another
Thanks for the patch. This clearly is a serious investment for PPC and is
definitely on the right path, we'll work with your to iron the remaining
issues
and get this landed.
Two high-level observations:
- Wherever possible, please don't add "#ifdef V8_TARGET_ARCH_PPC" in shared
platform code.
This port support 32 and 64 bits. Big Endian (BE) and Little Endian (LE).
There
is simulator support on Intel (Linux).
Proof points for "usefulness"
- A version of this code (3.14 level) is available in Ubuntu
https://launchpad.net/ubuntu/+source/libv8-3.14/3.14.5.8-5ubuntu2 supporting
PowerPC
23 matches
Mail list logo
