Committed patchset #8 manually as r15473 (presubmit successful).
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h#newcode1019
src/hydrogen.h:1019: static Representation ToRepresentation(Handle
type);
On 2013/07/02 12:03:09, danno wrote:
I think
Almost there
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h#newcode1019
src/hydrogen.h:1019: static Representation ToRepresentation(Handle
type);
I think it makes sense to move
PTAL, As discussed offline patchset 5 adds another BitField for the State
and
stores the operation as a Token::Value.
I did however not remove the State EnumSet, since GetExtraIcState() needs
to be
able to produce the ic_state without having access to the isolate,
therefore we
cannot use a
actually before you take another look at the original issue, you could
also consider this one:
https://codereview.chromium.org/18041003/
It basically builds on top of the previous one, but implements proper
x87 stack tracking instead of the crude hack.
It might be nice to not have to land th
PTAL
https://codereview.chromium.org/17229005/diff/116001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/17229005/diff/116001/src/code-stubs-hydrogen.cc#newcode756
src/code-stubs-hydrogen.cc:756: Handle UnaryOpStub::GenerateCode()
{
On 2013/0
https://codereview.chromium.org/17229005/diff/116001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/17229005/diff/116001/src/code-stubs-hydrogen.cc#newcode756
src/code-stubs-hydrogen.cc:756: Handle UnaryOpStub::GenerateCode()
{
Move this down
On 2013/06/21 16:38:04, danno wrote:
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc#newcode2164
src/arm/lithium-codegen-arm.cc:2164: int left_block =
instr->TrueDestination(chunk_);
Why this unrelated change?
neurosis?
it bothered me, that the definition of
On 2013/06/21 18:32:38, Rodolph Perfetta wrote:
drive by comments on ARM.
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc#newcode2036
src/arm/lithium-a
drive by comments on ARM.
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc#newcode2036
src/arm/lithium-arm.cc:2036: LOperand* value =
UseAtStart(instr->value
I _really_ like the direction this is going.
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc#newcode2164
src/arm/lithium-codegen-arm
12 matches
Mail list logo
