[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-15 Thread dslomov
Committed patchset #1 (id:60001) manually as 24638 (presubmit successful). https://codereview.chromium.org/613283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" gr

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-15 Thread dslomov
On 2014/10/15 12:50:17, caitp wrote: r24632 looks responsible for many of these failures (from a glance, could be wrong) Yes, nothing to worry about yet - the tree is closed anyway https://codereview.chromium.org/613283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.goo

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-15 Thread dslomov
Patch lgtm, will land (note to self: this needs blink expectations update) https://codereview.chromium.org/613283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" gr

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-14 Thread jkummerow
DBC to shed some light on test expectations: As the list notation kind of indicates, the status file defines sets of expected outcomes. If a test's actual outcome is not in the list of expected outcomes, it will be reported as a failure. No expectations, or an empty list, are equivalent to

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-14 Thread arv
Dmitry, care to review and land? https://codereview.chromium.org/613283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and s

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-14 Thread arv
LGTM https://codereview.chromium.org/613283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-14 Thread arv
On 2014/10/14 17:27:20, caitp wrote: On 2014/10/14 15:29:40, arv wrote: > https://codereview.chromium.org/613283002/diff/40001/test/test262/test262.status > File test/test262/test262.status (right): > > https://codereview.chromium.org/613283002/diff/40001/test/test262/test262.status#newcode9

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-10-14 Thread arv
https://codereview.chromium.org/613283002/diff/40001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/613283002/diff/40001/test/test262/test262.status#newcode97 test/test262/test262.status:97: '15.2.3.4-1-4': [SKIP], Based on the comments in o

[v8-dev] Re: Convert argument toObject() in Object.getOwnPropertyNames/Descriptors (issue 613283002 by caitpotte...@gmail.com)

2014-09-30 Thread arv
LGTM https://codereview.chromium.org/613283002/diff/1/test/mjsunit/es6/symbols.js File test/mjsunit/es6/symbols.js (right): https://codereview.chromium.org/613283002/diff/1/test/mjsunit/es6/symbols.js#newcode505 test/mjsunit/es6/symbols.js:505: // Object.getOwnPropertySymbols() does not throw w