[v8-dev] Re: Crankshaft: consolidated element loads always deopted on seeing the hole (issue 1329793003 by mvstan...@chromium.org)

2015-09-09 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1329793003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Crankshaft: consolidated element loads always deopted on seeing the hole (issue 1329793003 by mvstan...@chromium.org)

2015-09-09 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/164f92d206c6dc203c485a5c154e4aafa0c46c95 Cr-Commit-Position: refs/heads/master@{#30659} https://codereview.chromium.org/1329793003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Crankshaft: consolidated element loads always deopted on seeing the hole (issue 1329793003 by mvstan...@chromium.org)

2015-09-09 Thread mvstanton
Right on, thanks for the help thinking through it too. https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode7447 src/hydrogen.cc:7447: if (*map != isolate()->get_initial_j

[v8-dev] Re: Crankshaft: consolidated element loads always deopted on seeing the hole (issue 1329793003 by mvstan...@chromium.org)

2015-09-09 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329793003/40001 https://codereview.chromium.org/1329793003/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Crankshaft: consolidated element loads always deopted on seeing the hole (issue 1329793003 by mvstan...@chromium.org)

2015-09-09 Thread jkummerow
lgtm https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode7447 src/hydrogen.cc:7447: if (*map != isolate()->get_initial_js_array_map(map->elements_kind())) { Isn't this