[v8-dev] Re: Custom call IC for Math.floor. (issue3327022)

2010-09-21 Thread vitalyr
Thanks! The patch is now submitted. -- Vitaly http://codereview.chromium.org/3327022/diff/3001/4004 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/3327022/diff/3001/4004#newcode1163 src/ia32/disasm-ia32.cc:1163: int8_t imm8 = *reinterpret_cast(data + 1); On 2010/09/20 11

[v8-dev] Re: Custom call IC for Math.floor. (issue3327022)

2010-09-20 Thread erik . corry
LGTM http://codereview.chromium.org/3327022/diff/3001/4004 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/3327022/diff/3001/4004#newcode1163 src/ia32/disasm-ia32.cc:1163: int8_t imm8 = *reinterpret_cast(data + 1); Why not just: int imm8 = data[1]; ? http://codereview.chro